Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline code block #5297

Closed
wants to merge 1 commit into from
Closed

Fix inline code block #5297

wants to merge 1 commit into from

Conversation

johankj
Copy link
Contributor

@johankj johankj commented Feb 28, 2016

Added a zero-width space between , and ~ because emphasis blocks won't get parsed if they end with a comma.

This makes the inline code block show up correctly on GitHub and hopefully the website as well.
It's not a pretty hack, but it works.

@StreakyCobra
Copy link
Contributor

This is not the only place in the code having this (remind me of #2699). This may help you:

$ cd .emacs.d/
$ ag -Q ",~" -G org

Add zero-width space because emphasis blocks can't start/end with
a comma, an apostrophe or a quote.
@johankj
Copy link
Contributor Author

johankj commented Feb 28, 2016

Good catch. I've updated the commit with all broken code blocks I could find (those starting/ending with ,, ' or ").

@robbyoconnor
Copy link
Contributor

This is also against master -- Please close and reopen against develop and read our contribution guidelines before you do anymore contributing ;)

@johankj
Copy link
Contributor Author

johankj commented Feb 29, 2016

Don't know how I missed that. Sorry about that.
See #5305 for a PR against develop.

@johankj johankj closed this Feb 29, 2016
@johankj johankj deleted the patch-1 branch February 29, 2016 09:32
@robbyoconnor
Copy link
Contributor

It's fine, this is why I was gentle about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants